Closed gomorizsolt closed 4 years ago
Tasks that have yet to be done to make the PR ready for review:
README.md
@thisismydesign FYI, I've removed the configJSON
from the secrets and added CONFIG
with the values from config.yml
.
This error pops up for some reason. AFAICT it originates from the <Medium />
component. I'll look into it.
https://github.com/c-hive/dotdev/pull/106#issuecomment-614203004 => https://github.com/c-hive/dotdev/pull/106/commits/fc9d9e72d4478d76656170d80c58df17a3b4da83
It'd be great to make it less error-prone though, i.e. the /
at the end of the URL might not be added.
const slashRequired = proxy[proxy.length -1] === "/";
const feedUrl = `${proxy}{${slashRequired} ? "/" : ""}https://medium.com/feed/${username}`;
How about something like the above? Or let's just mention it somewhere in the doc.
It'd be great to make it less error-prone though, i.e. the / at the end of the URL might not be added.
The proper way of dealing with this is through a library that can parse and construct URLs/URIs. They should have a method for adding paths.
It'd be great to make it less error-prone though, i.e. the / at the end of the URL might not be added.
The proper way of dealing with this is through a library that can parse and construct URLs/URIs. They should have a method for adding paths.
Gotcha, thanks.
Issue #91.