c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/
MIT License
0 stars 1 forks source link

Proxify GitHub URLs #113

Closed gomorizsolt closed 4 years ago

gomorizsolt commented 4 years ago

Heads-up: AFAICT this only has an "effect" on local development presumedly because of the different protocols (i.e. HTTP vs HTTPS, the requests are initiated via HTTP locally).

One thing I've noticed is that "sometimes" the GitHub API complains about the missing CORS policy header (I can't provide exact details on when it happens and how to reproduce). I'd propose leveraging the newly introduced proxify() function to circumvent this issue.

thisismydesign commented 4 years ago

Normally we'd want to avoid that so decrease proxy load but feel free to enable it for the dev env.

gomorizsolt commented 4 years ago

Resolved by #116.