Closed gomorizsolt closed 4 years ago
Which UI glitch do you mean? 🙂
I mean the one that's detailed in #122.
Edit: I've updated the PR's description.
So there's a meaningful error message in place of the star icon if something goes wrong.
This still raises so I don't get how it resolves the issue. Let's talk about it but feel free to merge.
I don't get this. How could you reproduce the issue?
To clarify: without safeJsonResponse()
, the response coming from the GitHub API is still valid even if there's an error since it can be parsed to JSON.
{message: "Not Found", documentation_url: "https://developer.github.com/v3/repos/#get"}
That's the reason why we could see the "star" icon without any context (i.e. without title, description and tech icons).
(and also partially affects #128)
I don't recall this anymore, sorry. I'll take a look into it to what extent safeJsonResponse()
fixes the error described there.
So there's a meaningful error message in place of the star icon if something goes wrong.
Please don't display anything in this case.
This still raises so I don't get how it resolves the issue. Let's talk about it but feel free to merge.
I don't get this. How could you reproduce the issue?
To clarify: without safeJsonResponse(), the response coming from the GitHub API is still valid even if there's an error since it can be parsed to JSON.
I meant in the code but this makes sense then, nevermind.
Issue #122.