search

c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/
MIT License
0 stars 1 forks source link

Use TCC CDN script - [merged] #55

Closed thisismydesign closed 4 years ago

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 22, 2019, 13:56

_Merges issue-17use-tcc-script -> master

Issue #17.

Found the relevant SO topic that demonstrates the way of using imported script files in ReactJS.

Created a CDNDisplayer component, thus it's being used instead of SvgDisplayer.

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 22, 2019, 13:58

changed the description

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 22, 2019, 14:01

added 1 commit

Compare with previous version

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 22, 2019, 23:08

changed the description

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 22, 2019, 23:18

added 1 commit

Compare with previous version

thisismydesign commented 4 years ago

In GitLab by @thisismydesign on Apr 23, 2019, 01:36

CDN means Content Delivery Network, but this class is specific to our package and I guess also to JS stuff. How about naming it simply TeamContributionCalendar?

thisismydesign commented 4 years ago

In GitLab by @thisismydesign on Apr 23, 2019, 01:36

I think this comment makes more sense above line 13.

thisismydesign commented 4 years ago

In GitLab by @thisismydesign on Apr 23, 2019, 01:37

Please give this a nicer name :)

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:00

Yes, that makes more sense. Thanks!

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:04

changed this line in version 4 of the diff

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:04

changed this line in version 4 of the diff

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:04

changed this line in version 4 of the diff

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:04

added 1 commit

Compare with previous version

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:05

resolved all discussions

thisismydesign commented 4 years ago

In GitLab by @bencefrelli on Apr 23, 2019, 20:51

The code looks good to me and I tried the app in local and it works well.

But the SvgDisplayer.js and the related files not will be deleted?

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 20:56

Actually, I'm not sure whether we'd like to keep it in the repo or not.

Let's involve @thisismydesign in the discussion.

thisismydesign commented 4 years ago

In GitLab by @thisismydesign on Apr 23, 2019, 21:40

Good point, all the previous implementation should be removed.

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 23:49

added 1 commit

Compare with previous version

thisismydesign commented 4 years ago

In GitLab by @thisismydesign on Apr 23, 2019, 23:51

approved this merge request

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 23:54

merged

thisismydesign commented 4 years ago

In GitLab by @gomorizsolt on Apr 23, 2019, 23:54

mentioned in commit f18254f3dee08be4da0b5c196021151cff24f191