c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/
MIT License
0 stars 1 forks source link

Issue 71 Production deployment broken #73

Closed nkapolcs closed 4 years ago

nkapolcs commented 4 years ago

Bug #71
Fix our deployment workflow.

Changes:

nkapolcs commented 4 years ago

Does it really fix the production deployment? Did you make sure of it?

Képernyőfotó 2020-01-14 - 9 08 56

Have you seen these errors?

Thanks for noticing that, but I think this belongs to the #34 issue. I forked this repo and tried there to solve this problem, so I hope will work when we merge this PR to master.

gomorizsolt commented 4 years ago

but I think this belongs to the #34 issue.

If that belongs to a completely different issue then the fonts should not exist on the page.

tried there to solve this problem

And did you manage to solve it? :)

nkapolcs commented 4 years ago

but I think this belongs to the #34 issue.

If that belongs to a completely different issue then the fonts should not exist on the page.

I don't know exactly what you want to say, I think that will be enough if I fix the font appearance there.

tried there to solve this problem

And did you manage to solve it? :)

I was thinking about the current bug and we will see if we merge this issue.

gomorizsolt commented 4 years ago

I was thinking about the current bug and we will see if we merge this issue.

I don't get it. Could you solve the issue on the forked repo? I mean #71.

nkapolcs commented 4 years ago

I was thinking about the current bug and we will see if we merge this issue.

I don't get it. Could you solve the issue on the forked repo? I mean #71.

Yes, that's why I make this PR :)

thisismydesign commented 4 years ago

but I think this belongs to the #34 issue.

If that belongs to a completely different issue then the fonts should not exist on the page.

Unless there are some defaults. I can see those errors being caused by that issue, but we'll know for sure during that investigation.