Issue 74 add favicon - Githubissues

c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/

MIT License

0 stars 1 forks source link

Issue 74 add favicon #77

Closed nkapolcs closed 4 years ago

nkapolcs commented 4 years ago

Issue #74 Add favicon to the page.

Changes:

[x] add favicon
[x] rename static dir The static directory has been deprecated in favor of the public directory. https://err.sh/zeit/next.js/static-dir-deprecated

nkapolcs commented 4 years ago

In the #74 issue @thisismydesign mention:

Also add configuration entry for its path.

But if you drop the favicon to the public folder, it will work properly, because since NextJs 9.1:

public Directory Support: Define files to be mounted at the root of your application's URL (e.g. favicon.ico).

So create configuration entry could be misleading, but we could mention in the documentation. What do you think?

thisismydesign commented 4 years ago

@nkapolcs Agreed, thanks.

nkapolcs commented 4 years ago

Please update the example path for logo in the README and also add a mention of the favicon, you can make it a simple list under config:
- settings/settings.json
- public/favicon.ico

Thanks for the review.