Closed nkapolcs closed 4 years ago
In the #74 issue @thisismydesign mention:
Also add configuration entry for its path.
But if you drop the favicon to the public folder, it will work properly, because since NextJs 9.1:
public Directory Support: Define files to be mounted at the root of your application's URL (e.g. favicon.ico).
So create configuration entry could be misleading, but we could mention in the documentation. What do you think?
@nkapolcs Agreed, thanks.
Please update the example path for
logo
in the README and also add a mention of the favicon, you can make it a simple list under config:- settings/settings.json - public/favicon.ico
Thanks for the review.
Issue #74 Add favicon to the page.
Changes: