Bug 81 add head to index.js

c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/

MIT License

0 stars 1 forks source link

Bug 81 add head to index.js #85

Closed nkapolcs closed 4 years ago

nkapolcs commented 4 years ago

Issue #81 Favicon works locally but not in prod.

Changes:

[x] Add to the head
[x] fix console error

nkapolcs commented 4 years ago

In my fork, this fixed the problem, but the nextjs error continues to show.

Desktop screenshot (13)

nkapolcs commented 4 years ago

Now I fixed the console error.

Desktop screenshot (14)

nkapolcs commented 4 years ago

Cool, thanks.

Do we still use both pages/index.js and pages/_document.js? Couldn't they be merged?

I don't think that is possible, because index.js is our homepage default route, and _document.js is overwriting Document because of styled-component injecting the server side rendered styles into the <head>, and now our "custom" favicon.

thisismydesign commented 4 years ago

Alright, thanks.