c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/
MIT License
0 stars 1 forks source link

Issue 21 product showcase #86

Closed nkapolcs closed 4 years ago

nkapolcs commented 4 years ago

Issue #21
This section is to showcase products that are not open source or have a bigger scope so they cannot be showcased as git repositories.

Changes:

Visual:

Peek 2020-02-05 23-21

thisismydesign commented 4 years ago

Looks cool :)

Adjusted a few requirements:

Additionally:

Examples:

image

image

nkapolcs commented 4 years ago
  • Let's make it 1 row, N columns

    • example picture below
    • use pictures as heading for the cards (similar to mui example)
    • use pictures with ~7:3 ratio (do not constrain ratio)
    • fit 4-5 columns in a row on full-screen
  • technologies are in the same row as the name, aligned to the right

Additionally:

  • no need for learn more link, let's replace that with online presence icons aligned to the left

Oh i misunderstood the logo, thank for clarifying :)

nkapolcs commented 4 years ago

There is a design decision, and I'm curious about your opinion: So we have two options how we display the product grid, the first:

localhost 3000 (9)

We have fix grid element width as you can see above, and the second:

localhost 3000 (8)

Where we always fill the width of the container, no matter there is one grid element in the row or four. Which one to choose?

thisismydesign commented 4 years ago

Looks great!

Few comments regarding display:

I like the decision to match the height of the boxes to the biggest text. Created a follow-up for that: https://github.com/c-hive/c-hive.dev/issues/88 (but don't worry about it for now).

nkapolcs commented 4 years ago
  • Since there're pictures involved let's stick with your first proposed option. Then 4 products would be the limit, right?

Yes in one row 4 is the max (5 was too small).

Example: localhost 3000 (10)

gomorizsolt commented 4 years ago

Btw, sorry for not reviewing the last few PRs, I was unsubscribed from the notifications for some reason. :)