search

c-hive / dotdev

Next.js SPA professional website template for teams and individuals: https://c-hive.github.io/dotdev/
MIT License
0 stars 1 forks source link

Try to fix package lock #87

Closed thisismydesign closed 4 years ago

thisismydesign commented 4 years ago

@nkapolcs please check if your package.lock changes on this branch.

nkapolcs commented 4 years ago

In the other PR, I just run an npm install, and there was both modified status after I merge the master: https://github.com/c-hive/c-hive.dev/pull/86/commits/296ddbfc4635e98be839dfcbc3d9569d71ec5740 here you can see the diff.

And now when I run npm install nothing happened: Desktop screenshot (15)

I thought npm install shouldn't change package-lock.json, but now I'm not sure of it. Anyway i found this command maybe we should use it: npm ci

thisismydesign commented 4 years ago

We don't want npm ci. master should work as well, I was just wondering if this solves it. Having exact versions isn't nice either but if it helps I'm ok with this approach.