search

c-koi / gmic-qt

G'MIC-Qt is a versatile front-end to the image processing framework G'MIC.
GNU General Public License v3.0
207 stars 54 forks source link

Building translations now hard requires an Unix environment #150

Closed amyspark closed 1 year ago

amyspark commented 2 years ago

Hi @c-koi,

I just noticed you moved to a Makefile-based environment for generating the .ts files: 319adab966506e9e3b09d800e0f692cd997e5bd8 3e51329c08774adad1f5c27c52ae4f8674f21db3 24117741faacf127ac7634cbb159807e0c06e619.

The cited changes remove support for building G'MIC-Qt from Git using a Windows-based toolchain:

I'm not sure yet how these will be deployed in the next tarball, but for the time being, I've regenerated the .ts files on our side, and added some steps to build them automatically by taking advantage of qt5_add_translation and the AUTORCC property of CMake:

https://github.com/amyspark/gmic/commit/52c4e826a4960ed900237b40c20f11518c8a45c2

dtschump commented 2 years ago

@amyspark , we indeed plan to provide the generated .ts and .qm files in the tarball.

0xC0000054 commented 2 years ago

I also ran into this issue when building the Paint.NET and 8bf versions of G'MIC-Qt 3.1.3.

I worked around the issue by changing my build script to invoke csv2ts.sh using the Git for Windows bash shell, the .qm files are then compiled by calling the MinGW lrelease binary directly.