Update QRSDetectorOffline.py

c-labpl / qrs_detector

Python Online and Offline ECG QRS Detector based on the Pan-Tomkins algorithm

MIT License

176 stars 89 forks source link

Update QRSDetectorOffline.py #1

Closed davidgutierrez closed 7 years ago

davidgutierrez commented 7 years ago

modified so you can use the frameRate so you can used it as parameter
now the log and image file, are saved with the same name of the file.

msznajder commented 7 years ago

Hi there. Thanks for your work and update proposal. Right now we are not accepting any pull request to our module because we plan to keep it for now in "freeze" mode so it will be completely backwards compatible with all previous experiments. That is why I need to close this PR. Anyway I did small review in the comments to your changes. Cheers!

davidgutierrez commented 7 years ago

Hi Thanks for your feedback in this page i'm testing your detector: https://github.com/davidgutierrez/HeartRatePatterns/blob/master/Jupyter/GQRS%20detection%20Alternative.ipynb Right now im testing with the same data diferent detectors.