search

c-leri / Dynamic-Music

Adds more dynamic music and cues to Minecraft!
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Updated 1.16 Versions? #18

Closed Spongecade closed 1 year ago

Spongecade commented 1 year ago

I was working on my own fork of Dynamic Music specifically for the 1.16 versions, having fixed some of the bugs relating to daytime, and called it DynamicMusic-Legacy. I was going to publish it as It's own mod but is there a chance we could collab on this fork and you could create two branches for my updated 1.16 versions?

Spongecade commented 1 year ago

If you want to make one 1.16 architectury branch you could do that too although I've never used the architectury api

c-leri commented 1 year ago

I"ll open a 1.16 architectury branch! Just make a pull request into it and I'll take care of architectury

Spongecade commented 1 year ago

Should I just push the actual src folders for the forge and fabric version and their respective build scripts?

c-leri commented 1 year ago

Oh you made two separate version ! Honestly maybe I should make 1.16.5-fabric and 1.16.5-forge branches then and keep theme separated

Spongecade commented 1 year ago

Thank you for that! I will be pushing the branches shortly!

c-leri commented 1 year ago

Just know that I won't be able to look at your pull request before a few days but I'll get back to it as soon as possible!

Spongecade commented 1 year ago

That's ok. Thanks for the response!