search

c-mueller / ads

CoreDNS plugin to block ads. Inspried by PiHole.
Apache License 2.0
76 stars 12 forks source link

Expand whitelist/blacklist options to accept URL's and File-Locations #20

Open cbuijs opened 5 years ago

cbuijs commented 5 years ago

Would be nice if the whitelist and blacklist options accepts URL's and file-locations and maybe obsolete the list option?

Examples:

blacklist https://raw.githubusercontent.com/cbuijs/accomplist/master/deugniets/plain.black.domain.list
whitelist https://raw.githubusercontent.com/cbuijs/accomplist/master/deugniets/plain.white.domain.list
blacklist-regex /etc/coredns/my-sweet-regex.list
blacklist doubleclick.net
whitelist /etc/coredns/banks.list

etc...

c-mueller commented 5 years ago

I really like this idea. Especially because I was planning the support for local files anyways (#17). I will look into it. But it might take some time.

cbuijs commented 5 years ago

Love it.

On Sat, Jul 20, 2019, 14:09 Christian Müller notifications@github.com wrote:

I really like this idea. Especially because I was planning the support for local files anyways (#17 https://github.com/c-mueller/ads/issues/17). I will look into it. But it might take some time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/c-mueller/ads/issues/20?email_source=notifications&email_token=ABTKMUTW3JR4CB5KXNI6JSTQAL56PA5CNFSM4IFOCJ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NM7RA#issuecomment-513462212, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTKMUTR6NF4N5H7R3RIEYLQAL56PANCNFSM4IFOCJ2Q .

c-mueller commented 4 years ago

Alright after this Huge delay I finally got to implementing (most of) it. The only thing missing is Lacking support for regex rules in lists.

The features can be found in version 0.2.0 which is currently a prerelease because I want to test it a bit in depth before completeley releasing it.

To build it just Configure the plugins.cfg of coredns with the usual command (ignore the development part). Then run make and next replace the github.com/c-mueller/ads v0.1.4 line in the go.mod file with github.com/c-mueller/ads v0.2.0 and run make again, to get this version.

Thanks for your issue :)