juliaputko
commented
1 year ago Hi Hayley,
The files added to .gitignore were added because unless I added them, my installation of jekyll site related things would result in 10,000+ git changes among those related files.
I changed the name of the class in members.html. jptest was a name that I had chosen early on, and never changed. It is changed to people_ now.
cproof-deployments_argo.geojson is now cproof-deployments_all.geojson
I changed that one line in the description on the data page.
The blank pdfs are commented out.
I will make a new commit with all those changes, it should just append itself to the last pull request.
Best, Julia Putko
On Apr 25, 2022, at 10:08 AM, hvdosser @.***> wrote:
@hvdosser requested changes on this pull request.
Julia, can you take a look at all of my and Jody's comments, and either reply or make changes as is appropriate? The main concern is whether some of the git pages development code accidentally made it into the pull request. .
In .gitignore https://github.com/c-proof/cproofwebsite/pull/6#discussion_r857806822:
@@ -1,3 +1,8 @@ _site .sass-cache .jekyll-metadata + +.bundle/ +gliderdata/ +vendor/bundle/ruby/3.1.0/ Were these changes specific to git pages, or do we need them for the main website too?
In members.html https://github.com/c-proof/cproofwebsite/pull/6#discussion_r857824573:
@@ -32,32 +79,96 @@
{{ member.name }}
{% endif %}
+ Is "jptest" the right class for the live website or was it only for dev?In js/map.js https://github.com/c-proof/cproofwebsite/pull/6#discussion_r857826453:
@@ -23,7 +23,7 @@ var featureLayer = L.geoJson(null, { });
// Fetch the GeoJSON file -$.getJSON("/gliderdata/deployments/cproof-deployments.geojson", function (data) { +$.getJSON("/gliderdata/deployments/cproof-deployments_argo.geojson", function (data) { cproof-deployments_argo includes the ocean gliders and argo, right? It might be better to name it "cproof-deployments-all" instead, to avoid confusion.
In datapage.html https://github.com/c-proof/cproofwebsite/pull/6#discussion_r857846520:
+
- Direct download: Wget the data for all missions, by glider line, or by platform
- Deployments: View and download data and figures for individual glider missions
+
+
Data Description
+The different types of data files that are available are named as follows: Can we change this sentence to "As of 2022, the different types of data files that are available are named as follows: " ? Then I'll put it back after I catch up on updating the old directories to match the new naming conventions.
In datapage.html https://github.com/c-proof/cproofwebsite/pull/6#discussion_r857846823:
+
- Realtime: Subset of data transmitted via Iridium while the glider is in mission, with basic automated processing steps and QA/QC applied.
- Delayed: Full dataset collected by the glider and recovered post-mission, with all processing steps and QA/QC applied.
- Level 0 (L0) data: Merged raw data files, with no interpolation and no processing.
- Level 1 (L1) data: Time series or profile data with some interpolation and calculation of additional variables like salinity.
- Level 2 (L2) data: Gridded level 1 data, on a depth-time grid.
+
Data Processing
Open PDF Let's remove the blank PDFs for now (just comment out if possible), so they don't look like broken links.
In about.md https://github.com/c-proof/cproofwebsite/pull/6#discussion_r857830697:
+ +{% for post in site.data.inthenews %}{% if post.visible2 == true %} +
— Reply to this email directly, view it on GitHub https://github.com/c-proof/cproofwebsite/pull/6#pullrequestreview-952137179, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATOOXH4IF3XGZVFN2AXN3GDVG3GPRANCNFSM5R7ZXWNQ. You are receiving this because you authored the thread.
Hi Jody,
_includes/head.html https://github.com/c-proof/cproofwebsite/pull/6#discussion_r838142525: I removed site-url because I was having issues loading the css files during my testing, however I tested again just now, and it does not seem to be an issue, so I can revert it.
_layouts/data_jp.html https://github.com/c-proof/cproofwebsite/pull/6#discussion_r838142751 I use this file as a layout for the data.md page. To make the navigation bar, jekyll looks for the word “project” in the front-matter of layouts, so I made a separate layout for this page because I did not want it to appear in the top navigation bar.
about.m https://github.com/c-proof/cproofwebsite/pull/6#discussion_r838143293d : I will review the website you sent, and also talk about it with Hayley.
data.md https://github.com/c-proof/cproofwebsite/pull/6#discussion_r838144049 This page is accessible through the ‘wget data’ button on the deployments page. As for wgetting the data, this is also something decided by Hayley, so I will need to bring this up with her as well.
As for changing to raw html in markdown, I made css additions, and as to not clutter the index file with my css, I have added all the css to the bootstrap.css file - however for organizational purposes, and so as to not have to rename everything I added a class so that the css I added could be categorized under that class. (eg. .platforms .p { #css changes } )
Best, Julia Putko