search

c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
17 stars 24 forks source link

Fix time variable attributes for IOOS metadata #129

Closed hvdosser closed 1 year ago

hvdosser commented 1 year ago

Modified the attributes for the time variable in ncprocess.py to be compliant with IOOS requirements, including the calendar, units, and FillValue used.

jklymak commented 1 year ago

I think the errors in the tests are from hard-coded tests that you will just need to change in the test files.

hvdosser commented 1 year ago

@jklymak, am I clear to merge?

jklymak commented 1 year ago

@hvdosser and I noted that this didn't merge cleanly somehow. Given that the substantive changes are modest, let's revert and make a brand new PR where we are more careful about the merge.