c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
17 stars 24 forks source link

Update depth and time attributes for IOOS and fix tests #131

Closed hvdosser closed 1 year ago

hvdosser commented 1 year ago

Updated the time calendar in ncprocess.py, add depth attributes in utils.py, change processing script to use the new dbd reader code in test_pyglider.py (with option to use the old processing), and reran the 3 netcdf files that the tests compare against so that those files will include the updated attributes.

jklymak commented 1 year ago

The PR drops tests/results/example-slocum/L0-timeseries/dfo-rosie713-20190615.nc. Is that not needed?

codecov[bot] commented 1 year ago

Codecov Report

Base: 71.68% // Head: 77.49% // Increases project coverage by +5.81% :tada:

Coverage data is based on head (7a50c06) compared to base (67c6acd). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ========================================== + Coverage 71.68% 77.49% +5.81% ========================================== Files 7 7 Lines 1268 1271 +3 ========================================== + Hits 909 985 +76 + Misses 359 286 -73 ``` | [Impacted Files](https://codecov.io/gh/c-proof/pyglider/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof) | Coverage Δ | | |---|---|---| | [pyglider/utils.py](https://codecov.io/gh/c-proof/pyglider/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof#diff-cHlnbGlkZXIvdXRpbHMucHk=) | `67.54% <ø> (+0.37%)` | :arrow_up: | | [tests/test\_pyglider.py](https://codecov.io/gh/c-proof/pyglider/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof#diff-dGVzdHMvdGVzdF9weWdsaWRlci5weQ==) | `97.16% <50.00%> (-2.84%)` | :arrow_down: | | [pyglider/slocum.py](https://codecov.io/gh/c-proof/pyglider/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof#diff-cHlnbGlkZXIvc2xvY3VtLnB5) | `74.86% <0.00%> (+13.76%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.