search

c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
17 stars 24 forks source link

fix non-specified timebase defaults to work with parquet #137

Closed callumrollo closed 1 year ago

callumrollo commented 1 year ago

this fixes the failure flagged in #135. I neglected to update the timebase fallbacks when changing from pandas to parquet

jklymak commented 1 year ago

Oh weird - I had a comment, but must have erased it.

  1. Can you rebase on main so we get the codecov?
  2. I wonder if we should allow this fallback or just force users to specify timebase?
callumrollo commented 1 year ago

With the changes proposed in #128 I agree it would probably be better to force users to specify a timebase. That way, the user will know which sensor/variable they are using to align other timestamps with. I'll open another PR removing the fallbacks and returning an error message if timebase is not specified.

Not sure why codecov didn't run for this, it's up to date with c-proof/main