c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
17 stars 24 forks source link

Fixed time_profile variable units to be IOOS compliant. #141

Closed hvdosser closed 1 year ago

hvdosser commented 1 year ago

The variable time_profile had units that were e.g., 'seconds from 2022-12-01' but with the time changing for each profile. Code has been modified so the correct units will show up for all profiles. This fix also solved an issue where the value of time_profile was showing up as zero for some reason.

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.49% // Head: 77.49% // No change to project coverage :thumbsup:

Coverage data is based on head (918d3aa) compared to base (a32a585). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #141 +/- ## ======================================= Coverage 77.49% 77.49% ======================================= Files 7 7 Lines 1271 1271 ======================================= Hits 985 985 Misses 286 286 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jklymak commented 1 year ago

Can we add a test for this. e.g. test that the times are what we want when read back in?

hvdosser commented 1 year ago

I don't think we have any tests for the profile netcdf files right now, or for the gridded files. Do you want me to write one?