c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
17 stars 24 forks source link

replace 9999 data values with nan #143

Closed callumrollo closed 1 year ago

callumrollo commented 1 year ago

This PR will fix Issue #123 where 9999 error values from the legato are interpreted as valid pressures. All 9999 are replaced with nan during raw_to_timeseries.

Need to add tests.

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.49% // Head: 77.56% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (4a7c830) compared to base (a32a585). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 4a7c830 differs from pull request most recent head 3098843. Consider uploading reports for the commit 3098843 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #143 +/- ## ========================================== + Coverage 77.49% 77.56% +0.07% ========================================== Files 7 7 Lines 1271 1275 +4 ========================================== + Hits 985 989 +4 Misses 286 286 ``` | [Impacted Files](https://codecov.io/gh/c-proof/pyglider/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof) | Coverage Δ | | |---|---|---| | [pyglider/seaexplorer.py](https://codecov.io/gh/c-proof/pyglider/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof#diff-cHlnbGlkZXIvc2VhZXhwbG9yZXIucHk=) | `79.22% <100.00%> (+0.29%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.