c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
17 stars 24 forks source link

Fix for SeaExplorer code to avoid interpolating over large gaps #150

Closed hvdosser closed 1 year ago

hvdosser commented 1 year ago

This fix uses the same utils.findgaps function as the Slocum code, and only interpolates over gaps that are larger than the user-specified parameter maxgap.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (747863f) 79.62% compared to head (4d44e85) 79.65%.

:exclamation: Current head 4d44e85 differs from pull request most recent head 6dcc100. Consider uploading reports for the commit 6dcc100 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #150 +/- ## ========================================== + Coverage 79.62% 79.65% +0.02% ========================================== Files 7 7 Lines 1374 1376 +2 ========================================== + Hits 1094 1096 +2 Misses 280 280 ``` | [Impacted Files](https://codecov.io/gh/c-proof/pyglider/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof) | Coverage Δ | | |---|---|---| | [pyglider/seaexplorer.py](https://codecov.io/gh/c-proof/pyglider/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof#diff-cHlnbGlkZXIvc2VhZXhwbG9yZXIucHk=) | `82.03% <100.00%> (+0.12%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=c-proof)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.