search

c-proof / pyglider

glider software
https://pyglider.readthedocs.io/
Apache License 2.0
18 stars 27 forks source link

polars dependency not being added in a fresh installation #190

Open richardsc opened 1 month ago

richardsc commented 1 month ago

As noted in #188, when I install pyglider fresh, using miniconda on macOS14.5, the polars dependency is not installed, and has to be added manually. I tried on two different macOS machines (intel and arm), with the same result.

callumrollo commented 1 month ago

Thanks for raising this Clark! At the moment, the test matrix only tests against ubuntu-latest

https://github.com/c-proof/pyglider/blob/aa43c17c82ae4f53acb41fb3e59e00ef08183f3e/.github/workflows/tests.yml#L9

I'll put in a PR to add mac and windows. Hopefully that will show up the issue, as I don't have a mac here to test with.

callumrollo commented 1 month ago

It looks like polaras was added to the conda recipe in release 0.07 a couple of weeks ago

https://github.com/conda-forge/pyglider-feedstock/commit/00083d8c63e9d49cb4ad5ee12ae9799d7e53009d

Can you check if that resolves the issue? I'll still work on adding mac and windows to the test matrix to catch these issues earlier in future