c-ridgway / cpp-feather-ini-parser

Header only, simple, fast, templated - portable INI parser for ANSI C++.
MIT License
47 stars 14 forks source link

Fix parser usage in multiple compilation units #10

Open rjonaitis opened 3 months ago

rjonaitis commented 3 months ago

FIx INI parser usage in multiple .cpp compilation units linked together.

If A.cpp and B.cpp both include "INI.h" they each export the same functions causing one definition rule violation during linking stage. To avoid this problem, templated methods implementation has to be declared 'inline' and other supporting functions 'static'.

Because class static member INI::PARSE_FLAGS is not constant, it should be initialized only once. Currently each .cpp that includes the header is doing the initialization and generates undefined initialiation order error. Those variables need to be static per compilation unit.

API change: class static members INI::PARSE_FLAGS INI::SAVE_FLAGS moved out of class and renamed/made into static global variables, that can be initialized to unique values in each compilation unit.