search

c-w / gutenberg

A simple interface to the Project Gutenberg corpus.
Apache License 2.0
320 stars 60 forks source link

Changing default ordering of extensions for fetching ebooks #103

Closed lissyx closed 6 years ago

lissyx commented 6 years ago

Resolves https://github.com/c-w/gutenberg/issues/102

lissyx commented 6 years ago

@c-w Done, tell me if the wording is okay to you :)

lissyx commented 6 years ago

@c-w I'm also adding the .encoding change :)

MasterOdin commented 6 years ago

I'd ask that you add a --ascii or --prefer-ascii (with shorthand -a) into the argparse for this function.

lissyx commented 6 years ago

Sure, I'll add that.

lissyx commented 6 years ago

@MasterOdin Re-pushed with the command line argument :-)

MasterOdin commented 6 years ago

Looks good!

We'll want to bump the version to 0.7.0 for this since it's a slight backwards breaking change.

lissyx commented 6 years ago

@MasterOdin If you think we should not break backward compatibility, I'd be happy to change the behavior so that the default path stays the same as before :)

MasterOdin commented 6 years ago

I'm fine breaking it and this is probably preferable for most use cases, it's just something to be aware of and that it should be noted on the release page when a new release is cut.

lissyx commented 6 years ago

Then I guess someone needs to merge it, if it's good for you :-)

lissyx commented 6 years ago

Re-pushed, updating the version field.

c-w commented 6 years ago

Thanks a lot for the PR, @lissyx!