search

c-w / gutenberg

A simple interface to the Project Gutenberg corpus.
Apache License 2.0
320 stars 60 forks source link

Updating encoding for file open #113

Closed bwindsor22 closed 5 years ago

bwindsor22 commented 6 years ago

If the file encoding on your system (Linux, Windows, etc) is not set to utf-8, this line could cause problems when reading non-ascii characters from the Readme. This simplifies the open() statement so that the pip installation is less dependent on system variables.

bwindsor22 commented 6 years ago

See Python3 What's New: https://docs.python.org/3.0/whatsnew/3.0.html

"Files opened .... It also means that even Unix users will have to specify the correct mode (text or binary) when opening a file.... In many cases, but not all, the system default is UTF-8; you should never count on this default."

bwindsor22 commented 5 years ago

... thanks. Sorry to leave this hanging.

On Thu, Dec 6, 2018 at 10:04 PM Clemens Wolff notifications@github.com wrote:

Merged #113 https://github.com/c-w/gutenberg/pull/113 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/c-w/gutenberg/pull/113#event-2011482944, or mute the thread https://github.com/notifications/unsubscribe-auth/AYL2zChK11NVjfG5SuAGgCHCbEfpfv_mks5u2dq5gaJpZM4WfuYg .