search

c-w / gutenberg

A simple interface to the Project Gutenberg corpus.
Apache License 2.0
320 stars 60 forks source link

Update install for BerkeleyDB #116

Closed nateGeorge closed 5 years ago

nateGeorge commented 5 years ago

On Ubuntu 16.04, the library in the Readme doesn't work. I added another line with the version of the library that worked for me.

c-w commented 5 years ago

This is great, thanks for the pull request. Could you please resolve the conflicts so that we can get this merged?

nateGeorge commented 5 years ago

Hmm, I just now noticed the line sudo apt-get install libdb++-dev later down in the readme; isn't that the better option than sudo apt-get install libdb5.1-dev or sudo apt-get install libdb5.3-dev?

MasterOdin commented 5 years ago

Looking at this, it looks like your fork is based on a fork that's several years old and well over a hundred commits behind.

I do agree that leaving it as is in the README currently is correct.

Do we want to incorporate some of these text dividers into master?

nateGeorge commented 5 years ago

Hmm, yes, sorry about that. When I went to the repo through Google, this one came up as the 2nd result: https://github.com/ageitgey/Gutenberg

and I didn't notice it was a fork of this one. Then when I went for the pull request, I didn't notice it was pulling into this repo. Sorry, disregard this pull.