search

c-w / gutenberg

A simple interface to the Project Gutenberg corpus.
Apache License 2.0
320 stars 60 forks source link

Add support for Python 3.8 #128

Closed hugovk closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #128 into master will increase coverage by 0.23%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   95.74%   95.97%   +0.23%     
==========================================
  Files          29       29              
  Lines        1033     1094      +61     
==========================================
+ Hits          989     1050      +61     
  Misses         44       44
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) :arrow_up:
gutenberg/query/extractors.py 100% <0%> (ø) :arrow_up:
tests/_util.py 100% <0%> (ø) :arrow_up:
tests/_sample_metadata.py 100% <0%> (ø) :arrow_up:
tests/_sample_text.py 100% <0%> (ø) :arrow_up:
gutenberg/acquire/text.py 100% <0%> (ø) :arrow_up:
tests/test_util.py 95.12% <0%> (+0.12%) :arrow_up:
tests/test_acquire.py 97.02% <0%> (+0.22%) :arrow_up:
gutenberg/acquire/metadata.py 91.74% <0%> (+0.51%) :arrow_up:
gutenberg/query/api.py 96.61% <0%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 378a7b4...fd43753. Read the comment docs.

hugovk commented 4 years ago

The Windows wheel for Python 3.8 has a different filename than for earlier versions:

https://github.com/c-w/gutenberg/pull/128/commits/fd437532f4d54a6af63e53c71a16ad821157142a adds an extra condition to the step to check for minor version != 8, and an extra step with the condition for minor version == 8. That's quite a bit of duplication to handle a single extra character in the filename! Perhaps some duplication can be removed?