search

c-w / gutenberg

A simple interface to the Project Gutenberg corpus.
Apache License 2.0
321 stars 59 forks source link

Add upper version limit for rdflib #131

Closed MasterOdin closed 4 years ago

MasterOdin commented 4 years ago

rdflib 5.0.0 reworked some amount of their interface, which breaks things here. Minimally, SPARQLWrapper is no longer used, and a requests based wrapper internal to rdflib is now used, which breaks compatibility with older RDF stores that do not follow the SPARQL Protocol 1.1 spec. Setting this to minimize the break here, with a look to move to rdflib 5 in the next major version bump of gutenberg itself.

codecov-io commented 4 years ago

Codecov Report

Merging #131 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          29       29           
  Lines        1033     1033           
=======================================
  Hits          989      989           
  Misses         44       44
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 378a7b4...3a7fca9. Read the comment docs.

MasterOdin commented 4 years ago

Will fix the azure pipelines and then merge.