c-w / gutenberg

A simple interface to the Project Gutenberg corpus.
Apache License 2.0
320 stars 60 forks source link

Fix install on MacOS with Python 2.7 #137

Closed c-w closed 3 years ago

c-w commented 3 years ago

The CI on MacOS and Python 2.7 started failing when bsddb 6.2.8 was released (see failed build log and failed build screenshot).

Given that Python 2.7 is deprecated, this pull request works around the issue by pinning bsddb to 6.2.7 or earlier for the affected combination of OS and Python version (see successful build log).

codecov-io commented 3 years ago

Codecov Report

Merging #137 (a06928d) into master (79b8f4a) will decrease coverage by 0.17%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   95.97%   95.80%   -0.18%     
==========================================
  Files          29       29              
  Lines        1094     1096       +2     
==========================================
  Hits         1050     1050              
- Misses         44       46       +2     
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79b8f4a...4502870. Read the comment docs.