Support Python 3.2 - Githubissues

c-w / gutenberg

A simple interface to the Project Gutenberg corpus.

Apache License 2.0

320 stars 60 forks source link

Support Python 3.2 #54

Closed hugovk closed 7 years ago

hugovk commented 7 years ago

Closes https://github.com/c-w/Gutenberg/issues/49.

The build fails because requests no longer supports Python 3.2.

If 3.2 is still desired for this project:

then pin the required requests version to the last one that supports 3.2.
this PR could be improved by only pinning the requests version on Python 3.2, and allowing other Pythons to use the most recent.

But see also PR https://github.com/c-w/Gutenberg/pull/53 that removes support for 3.2.

MasterOdin commented 7 years ago

I'm more in favor of #52 as I don't think 3.2 is that widely used version anywhere (with the last release being 2+ years ago) and we could remove a compatibility shim as well, but I'd like @sethwoodworth opinion on this as we never made a final decision for #49.

hugovk commented 7 years ago

I'm more in favor of #52

Surely you mean #53 :)

sethwoodworth commented 7 years ago

@MasterOdin Agreed. Closing in favor or #53. Thank you @hugovk