search

c-wenlong / pe

0 stars 0 forks source link

No upper limit for phone number leading to ugly UI #6

Open c-wenlong opened 7 months ago

c-wenlong commented 7 months ago

Description

Screenshot 2024-04-19 at 16.41.45.png

There is no upper limit on the number of digits a mobile number can have, which leads to some of the digits not showing on the UI.

Fix

Consider implementing an upper limit on the phone number since we know there exist an upper limit in the world (probably).

nus-pe-script commented 7 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Text Overflow on Edit Phone Number

As can be seen below, when a user inputs a phone number that is too long, it causes an overflow in the UI for the phone number and hence the user will not be able to see the whole number.

Screenshot 2024-04-19 at 4.44.18 PM.png

This error can simply be fixed by limiting the number of valid numbers a user can enter in the phone prefix

[original: nus-cs2103-AY2324S2/pe-interim#970] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [x] I disagree **Reason for disagreement:** This is a cosmetic flaw, in the real world, no one should possess a phone number that long, hence, `VeryLow` should be the right severity.