c-yn / SFNet

[ICLR 2023] Selective Frequency Network for Image Restoration
MIT License
97 stars 9 forks source link

about the SRRS in desnowing task #9

Closed chensming closed 9 months ago

chensming commented 9 months ago

Hello, when I finished downloading the SRRS dataset, I found two problems, 1)the training collection dataset has overlapping images, such as the red box in the image

image

2) The training and test sets have duplicate images, and the training set is shown in the green box above. A similar situation exists with test sets such as 302.jpg and 303.jpg

image

I hope you can answer my questions, thanks in advance!

c-yn commented 9 months ago

Thanks for your question.

This is because different snow patterns correspond to the same gt (background).

chensming commented 9 months ago

Thanks for your reply.

Yeah you're right. But another question is, it seems like the authors didn't take this into consideration when dividing the training and test sets, which then leads to the same scenarios in the training and test sets, e.g. 0.jpg in the training set and 1.jpg in the test set have the same scenarios, which seems like it would lead to high metrics for the model?

chensming commented 9 months ago

Also, I noticed that the CSD dataset downloaded from the link you provided on readme.md has an overlap between the training set and the test set. image

c-yn commented 9 months ago

Hi, CSD shares the same gt/background between training and testing sets.

chensming commented 9 months ago

Hi, CSD shares the same gt/background between training and testing sets.

ok. Thanks.