search

c00kiemon5ter / monsterwm

tiny but monstrous tiling window manager
https://github.com/c00kiemon5ter/monsterwm
Other
335 stars 44 forks source link

Resizing can crash monsterwm #10

Closed mil closed 12 years ago

mil commented 12 years ago

If you resize in tiling mode there is no catch to see if you are setting W/H of XMoveResizeWindow() to 0. Thus it is possible to crash monsterwm while resizing. To see this happen: Start monsterwm, launch two windows. Hold down Alt+l. When a window is calculated as 0 width, monsterwm will crash.

See my fix here: https://github.com/mil/monsterwm/commit/5e104b4eb299f569bea4034eebd3cf58d4efdfee

c00kiemon5ter commented 12 years ago

the check is against MINWMSZ (aka minimum window size). there was a wrong logic operator there. thanks for catching and reporting this ;)

closed by fixed commit 534c8e5d8d1d654ae52a0b1f10a24baec7c18739

c00kiemon5ter commented 12 years ago

btw, this can happen with stack resize too. there is no checking there, but making windows so small doesn't make much sense or make them any useable.

I should probably add size checks there too. I've commented on this on the arch forums, and iirc on that commit (which, tbh, might have been rebased)

keep in mind that some apps (ie gvim) need a minimum size that is far greater than 1px.