c0b / docker-elixir

Official Docker image for Elixir :whale: :turtle: :rocket:
http://elixir-lang.org/
190 stars 74 forks source link

Tighter version constraints for Erlang/OTP #107

Closed dideler closed 5 years ago

dideler commented 5 years ago

We've had a few issues where building a new image for our release has upgraded the Erlang/OTP version automatically because the Elixir images only specify the Erlang major version.

For example, the Elixir 1.7 image has

FROM erlang:21

Which means minor and patch version upgrades happen automatically.

The most recent time this has bitten us was yesterday. According to the Erlang bug board [1,2] and Elixir + Erlang Slack groups, others have also been affected.

  1. https://bugs.erlang.org/browse/ERL-883
  2. https://bugs.erlang.org/browse/ERL-884

One option is to give consumers more flexibility in terms of version constraints.

For example, tags can use a convention such as this which locks on an OTP minor version, giving more control on when to upgrade, while allowing patches to come through.

1.7-otp-21
1.7-otp-21.2

1.7.4-otp-21
1.7.4-otp-21.2

What do you think about the proposal?

mikekelly commented 5 years ago

Less mutability in the images would be welcome. We got bitten by this last week when it bumped erlang to 21.3

mikekelly commented 5 years ago

👏