Introduce OTP-21.2 to versions 1.7 and 1.8

shdblowers commented 5 years ago

Hello,

Not sure if this is 100% correct or the approach that is wanted, but had a go at trying to fix #107.

c0b commented 5 years ago

+1 for the PR, let me have some local building tests

for future if we can foresee the incompatibilities, would be also better to make a fork

c0b commented 5 years ago

I think the issue #107 is more on prod deployment, it's about the alpine variant,

See https://github.com/c0b/docker-elixir/compare/pr/otp-21.2-branch?expand=1 I've just pushed for another branch

shdblowers commented 5 years ago

I work at the same comany as the guy who opened the issue and I can tell you we don't use alpine.

c0b commented 5 years ago

I see; I've just refreshed #110 to include both with original authoring ; it's like a superset of this PR, while just one change to keep whitespacing as consistent with others (tabs); please make sure when do you diff, only the FROM ... line is showing up

➸ diff -urNp -- ./1.8/Dockerfile ./1.8/otp-21.2/Dockerfile
--- ./1.8/Dockerfile    2019-03-20 19:42:53.714149389 -0500
+++ ./1.8/otp-21.2/Dockerfile   2019-03-21 10:18:18.003843516 -0500
@@ -1,4 +1,4 @@
-FROM erlang:21
+FROM erlang:21.2

 # elixir expects utf8.
 ENV ELIXIR_VERSION="v1.8.1" \

c0b / docker-elixir

Introduce OTP-21.2 to versions 1.7 and 1.8 #109