search

c0b / docker-elixir

Official Docker image for Elixir :whale: :turtle: :rocket:
http://elixir-lang.org/
190 stars 73 forks source link

Add git by default #3

Closed danhper closed 8 years ago

danhper commented 8 years ago

Hi,

I think It would be more CI friendly if git could be installed by default, as it is often used to fetch projects, or dependencies.

What do you think?

c0b commented 8 years ago

the only concern is the image size, either to have more tools to be developer / CI friendly, or to have less tools to be production deployment friendly?

  1. https://hub.docker.com/_/erlang/
  2. https://imagelayers.io/?images=erlang:18.3,erlang:18.3-slim,erlang:18.3-onbuild,erlang:17.5.6.8,erlang:17.5-slim

this elixir image is currently based on erlang:18-slim image, which is 288MB, if switched to the standard erlang:18 (748MB) and be buildpack-deps based (which most programming language images based on, python, ruby, nodejs, ...), we'll get git and some other developer friendly tools as well, we can make the switch or keep both, the switch will make the image larger and keep both is just some more developer effort; is it really wanted? I want to hear some more voices here

danhper commented 8 years ago

@c0b Thanks for the reply. I am aware the image size will increase, but I think that this image should be used more for development than for production, the rational being that the dependency on Elixir is unneeded in production, so an erlang image should be enough. At least for my use case, I build everything on my build server, and deploy with exrm to my production server where I do not have any depedency on Elixir. I would therefore personally be in favor of making the switch, but it would indeed be good to have some other voices.