search

c0bra / deviceframe

:iphone: Put device frames around your mobile/web/progressive app screenshots.
Other
582 stars 16 forks source link

Licence #14

Closed jacobp100 closed 6 years ago

jacobp100 commented 6 years ago

I'm working on a project that will be implementing framing like this. The gist is it renders react native apps to images without a simulator.

I wanted to add a <Frame> component so somebody could frame the screenshot, and then use other react native components to annotate it (screenshot titles etc.) You can see a gist here

To do this, it would be really handy to use your frames.json and device-dimensions.json files. However, the GPL license will make it hard for people to use this project. Would it be possible to re-licence this file with a permissive license like MIT?

c0bra commented 6 years ago

Yes I can so that

On Sat, Jun 2, 2018, 5:36 AM Jacob Parker notifications@github.com wrote:

I'm working on a project https://github.com/jacobp100/react-image-export that will be implementing framing like this. The gist is it renders react native apps to images without a simulator.

I wanted to add a component so somebody could frame the screenshot, and then use other react native components to annotate it (screenshot titles etc.) You can see a gist here https://github.com/jacobp100/react-image-export/blob/master/packages/integration/index.snap.js

To do this, it would be really handy to use your frames.json file. However, the GPL license will make it hard for people to use this project. Would it be possible to re-licence this file with a permissive license like MIT?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/c0bra/deviceframe/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGaL3am-wwUEG-J6ESCqj6Btr9GTd-vks5t4mqwgaJpZM4UXo85 .

c0bra commented 6 years ago

@jacobp100 you should be good to go!

jacobp100 commented 6 years ago

Thanks a lot! 🙏

jacobp100 commented 6 years ago

Just to clarify, is deviceframe-frames just reusing Facebook's licence? I think it'll be easier to just use this repo so stuff is in sync 😀

c0bra commented 6 years ago

I searched and searched for Facebook's license on their frames and couldn't find anything.

The repo is separate to prevent unnecessary clutter. Not every frame is required for any particular person's needs.