Use puppeteer instead of phantomjs

c0bra / deviceframe

:iphone: Put device frames around your mobile/web/progressive app screenshots.

Other

580 stars 16 forks source link

Closed ramonszo closed 5 years ago

c0bra commented 5 years ago

@ramon82 I've been waiting for screenshot-stream to update internally to use puppeteer but it looks more and more like that's not going to happen.

Your PR includes a bunch of lint errors. Can you run yarn test locally and get it cleaned up? Then I'll take a look. Thanks!

ramonszo commented 5 years ago

Ok!

ramonszo commented 5 years ago

Hey @c0bra I think there's some compatibility issues with your building system.. Can you check this? The code passes all tests

c0bra commented 5 years ago

@ramon82 ah yea, it's trying to run against node v4. Lemme disable that.

c0bra commented 5 years ago

I need to close and reopen this to get travis to update the config.