c0defellas / enzo

core utilities
11 stars 2 forks source link

kill: code style and tests #21

Closed i4ki closed 7 years ago

i4ki commented 7 years ago

Add some tests.

Closes #9 Closes #23

geyslan commented 7 years ago

@tiago4orion, I took the liberty of making a little refactoring in your PR. Kill test unit passed here. :+1:

i4ki commented 7 years ago

Nice! Thanks @geyslan

i4ki commented 7 years ago

I see the following output in the travis build log:

-ne         
1.1M /home/travis/gopath/bin/echo
-ne         
1.1M /home/travis/gopath/bin/cat
and so on

This "-ne" is due that since enzo's echo was just installed in GOPATH, the Makefile is using it to print. But our echo doesn't support -e (by design). We need to update the Makefile to use only enzo's syntax in tools.