c0fec0de / anytree

Python tree data library
Apache License 2.0
947 stars 133 forks source link

Missing type annotations #252

Open CoolCat467 opened 8 months ago

CoolCat467 commented 8 months ago

While using this project in a project of my own, when type checking my project I found that there are no type annotations for this project and therefore the type checker I am using reports that it's unable to give accurate results because this project is untyped.

I would potentially be willing to work on adding type annotations, but in the past with other projects they've said that it would be better to make an issue about it first and see if it would be worth doing instead of putting the work in to make a pull request and not have it merged.

c0fec0de commented 8 months ago

Contribution is welcome.

Yeah, fill a pull request

CoolCat467 commented 8 months ago

First batch, adding type annotations for nodes: https://github.com/c0fec0de/anytree/pull/253

dzmitry-lahoda commented 7 months ago

Also https://realpython.com/python312-typing/ removes some types boilerplate .

@CoolCat467 if you accept cryptodonations in anything (like USDC/USDT/whatever), not big, just share you wallet.

dzmitry-lahoda commented 7 months ago

@c0fec0de may you add CI to run on #253? that is by either invite of @CoolCat467 to project or modifying CI job/project settings.

c0fec0de commented 7 months ago

Will Take Care next week

dzmitry-lahoda @.***> schrieb am Mi., 14. Feb. 2024, 10:55:

@c0fec0de https://github.com/c0fec0de may you add CI to run on #253 https://github.com/c0fec0de/anytree/pull/253? that is by either invite of @CoolCat467 https://github.com/CoolCat467 to project or modifying CI job/project settings.

— Reply to this email directly, view it on GitHub https://github.com/c0fec0de/anytree/issues/252#issuecomment-1943421280, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE77IH66MQQKBJGFQWDDYZLYTSC2HAVCNFSM6AAAAABB5X53E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGQZDCMRYGA . You are receiving this because you were mentioned.Message ID: @.***>