search

c0ldplasma / gnome-shell-extension-taskbar

Development stopped - GNOME Shell Extension TaskBar 2020 (GNOME 3.30-(3.)40)
https://extensions.gnome.org/extension/2506/taskbar-updated/
GNU General Public License v3.0
24 stars 9 forks source link

Extension crashes when removing bottom panel #1

Closed c0ldplasma closed 4 years ago

c0ldplasma commented 4 years ago

When bottom panel is on and then gets removed by

  1. Disabling the extension or
  2. Disabling the bottom panel setting the extensions crashes and can not be enabled again until new gnome session.

Fedora 31 GNOME 3.34

`Object St.Button (0x562e3ad4a0a0), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs. == Stack trace for context 0x562e3a018600 ==

0 7fffd5db92a0 b resource:///org/gnome/gjs/modules/overrides/GObject.js:517 (7f368c0ad8b0 @ 25)

1 562e3c16c460 i /home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/extension.js:2486 (7f362ca6c160 @ 20)

2 7fffd5dba5f0 b self-hosted:261 (7f368c0bd040 @ 223)

3 7fffd5dbb240 b /home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/extension.js:2484 (7f362ca6c0d0 @ 353)

4 562e3c16c3d0 i /home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/extension.js:2121 (7f362ca69550 @ 17)

5 7fffd5dbc590 b /home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/windows.js:104 (7f362ca84670 @ 224)

6 7fffd5dbc660 b self-hosted:979 (7f366412f940 @ 440)

JS ERROR: Error: Argument 'instance' (type interface) may not be null _init/GObject.Object.prototype.disconnect@resource:///org/gnome/gjs/modules/overrides/GObject.js:517:16 cleanTasksList/<@/home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/extension.js:2486:6 cleanTasksList@/home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/extension.js:2484:4 onWindowsListChanged@/home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/extension.js:2121:9 buildWindowsList@/home/plasmari/.local/share/gnome-shell/extensions/TaskBar@c0ldplasma/windows.js:104:3`

c0ldplasma commented 4 years ago

df580e76d95907c74e6041fbd2e5e58d8ea7c377 "Fixed" by surrounding the lines which cause the error with empty try...catch...

Probably not the best idea, but works for now.