c0ldplasma / gnome-shell-extension-taskbar

Development stopped - GNOME Shell Extension TaskBar 2020 (GNOME 3.30-(3.)40)
https://extensions.gnome.org/extension/2506/taskbar-updated/
GNU General Public License v3.0
24 stars 9 forks source link

Align option does not move the Desktop Button #16

Open parampreetss opened 3 years ago

parampreetss commented 3 years ago

I have been trying to move the desktop button to extreme right of the panel so that this button could be clicked without actually looking at it. The left and right buttons in the align option (Overview tab) have no effect on desktop button. The button does not move at all. I am able to move the button using "Align Taskbar" in the Panel tab, but it gets reset after GNOME shell restarts.

danogh commented 3 years ago

I'd like to see the buttons either at the far left or far right. Having the buttons move when the number of windows changes is problematic.

This is a change that I could implement. Let me know if you'd like to see what I propose.

parampreetss commented 3 years ago

Thanks. That would fix the issue I reported. And if the user has an option to select between far left and far right, that would be even better as different people would prefer different alignment. Does your change only affects the bottom panel? Isn't it possible with the top panel as well? (Originally I observed the issue while using top panel)

danogh commented 3 years ago

I submitted a pull request with a possible fix. It puts the buttons on the outside edges of the screen, keeping them from the expandable parts of the task list.

You can try out out by pulling extension.js from my repo: https://github.com/danogh/gnome-shell-extension-taskbar/tree/buttons-outside

You will need to restart gnome-shell after replacing the file. Move the various buttons around with the configuration and see what it does.

parampreetss commented 3 years ago

I copied incorrect file to the directory and reported an error. My bad, apologies. Deleted that comment. Tested again using the correct file, the show desktop button appeared on extreme left of the bottom panel and worked well there. But the button does not appear anywhere on the top panel. I retied after disabling other extensions which affect the panel (Unite, ArcMenu and Dynamic Panel Transparency), but still the button did not appear.

danogh commented 3 years ago

Thanks for testing the top panel. There are several ways I can fix that. I’ll work on an update.

danogh commented 3 years ago

I submitted a new version to my repository that restores the behavior of the top panel. Please test that it works as expected.

parampreetss commented 3 years ago

Thanks for the update. The button appeared back on top panel. But it still has the original problem that I reported. I can't move it to extreme right of the panel permanently. Align option has no effect on the button and changes made using "Align Taskbar" option get reset on shell restart.

danogh commented 3 years ago

I misunderstood what you were looking for. I strictly use the bottom panel so I was thinking in that frame of reference.

Where is it that you want the task bar and desktop button? The top panel has Activities, Application Menu, Clock, and Notification Area. The only place I cannot put the tasks and buttons is to the right of the Notifications. Is that where you are wanting the desktop button?

parampreetss commented 3 years ago

I use the panel at top and I wanted to align the desktop button to the extreme right of the top panel. This way I'd be able to click on the button without consciously looking at the button (Just push the mouse towards top right and click). There is an align option already in the overview tab, but it has no effect on the desktop button. The "Align Taskbar" option in the Panel tab moves the button, but it gets reset after GNOME shell restarts. I am attaching the current view (first image) and the desired alignment (second image). Hope it helps. CurrentView DesiredAligned

danogh commented 3 years ago

So you are using TaskBar 2020 only for the show desktop button? I can put the button to the far right and it stays when I restart gnome-shell or log in or out. It does move if I toggle Tasks on and off. I'm not entirely sure why it moves for you when you restart gnome-shell or when I toggle the Tasks. My current patch does not address this issue, but I may look at it when I'm done with the current patch.

parampreetss commented 3 years ago

Well, currently I am using TaskBar 2020 only for the show desktop button. But that was not my primary reason for installing the extension. My target was to move everything that is not frequently clicked, to the middle of the panel (the GNOME system tray/power button menu, caps lock indicator etc.). Wanted to achieve something like this: Screenshot from 2020-10-15 11-27-52Later I realized that there is no extension that can move the system tray (or I could not find any).

Back to this issue, in my case it gets reset after shell restarts. Tried everything (removed all other extensions which affect the panel, reinstalled TaskBar2020), nothing worked. How do you align the button? Does the Align option in overview tab work for you, or do you use Align Taskbar in the Panel Tab?