search

c0re100 / qBittorrent-Enhanced-Edition

[Unofficial] qBittorrent Enhanced, based on qBittorrent
https://github.com/c0re100/qBittorrent-Enhanced-Edition
Other
19.84k stars 1.27k forks source link

Appimage version doesn't use system theme #621

Closed Bryan2333 closed 3 weeks ago

Bryan2333 commented 3 weeks ago

qBittorrent & operating system versions

Here is the qbittorrent enhanced information: qBittorrent-Enhanced: 5.0.0.10(64bit) Qt: 6.8.0 Libtorrent: 1.2.19.0 Boost: 1.86.0 OpenSSL: 3.4.0 zlib: 1.3.1

Here is my system information: Operating System: Arch Linux KDE Plasma Version: 6.2.2 KDE Frameworks Version: 6.7.0 Qt Version: 6.8.0 Kernel Version: 6.10.10-zen1-1-zen-cjktty (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 5800H with Radeon Graphics Memory: 13.5 GiB of RAM Graphics Processor: AMD Radeon Graphics

What is the problem?

The appimage version does not respect system theme.

Steps to reproduce

  1. Just launch qbittorrent-enhanced

Additional context

Here is the screenshot of the appimage download from release q1

Here is the screenshot of qbittorrent-enhanced from AUR, which is built from source. q2

You can see the difference obviously.

Log(s) & preferences file(s)

No response

abcfy2 commented 3 weeks ago

Known issue. We force set qt to use GTK theme. See: https://github.com/c0re100/qBittorrent-Enhanced-Edition/issues/341#issuecomment-1066018193

Bryan2333 commented 3 weeks ago

If you're using KDE, in addition to set a plasma theme, you should also set a similar GTK theme.

It seems that the GTK theme has been set to Breeze already.

Snipaste_2024-10-30_12-47-38

Some other GTK application like solaar in system is using Breeze theme, qbittorrent enhanced should use Breeze too. But they look quite different.

Snipaste_2024-10-30_12-50-34

abcfy2 commented 3 weeks ago

Would you please try this build ? https://github.com/abcfy2/qBittorrent-Enhanced-Edition/releases/tag/v5.0.0.12

I guess it may be the influence of gtk2 style. Currently I removed qt6gtk2 from AppImage build since gtk+ plugin in qt-base already works fine, and next release will use this patch.

Bryan2333 commented 3 weeks ago

Snipaste_2024-10-30_14-02-20

Other than the background color, I don't see a difference in the buttons, dropdown menus, and other components

abcfy2 commented 3 weeks ago

So that's might be the qt style used gtk theme. Since it's not a real GTK application, so maybe a little different style from GTK application.

I think it's not a AppImage problem. So you may close this issue now.