search

c0z3n / pySimpleDMX

pysimpledmx is a simple dmx control module in python, for the Enttec DMX USB Pro
59 stars 22 forks source link

Cant specify channel 1 #15

Open artBoffin opened 7 years ago

artBoffin commented 7 years ago

It appears this part of the code throws an error while trying to set channel 1:

if not 1 <= chan-1 <= DMX_SIZE:

Channel 2 is mapping to channel 1 though when send to the fixture... confusing

ccorn90 commented 6 years ago

bump

The subtraction of 1 to allow the data structure to be a list makes sense, but the bound on line 46 is wrong... should be if not 0 <= chan-1 <= DMX_SIZE. It blows up when attempting to set the first channel.

fishymander commented 6 years ago

bump

this is still an issue

gregoryyoung2 commented 6 years ago

It looks like all channels are offset by -1, so to update channel 1 ask to update channel 2, to update channel 10 ask to update channel 11.