search

c10l / cookbook-deploy_key

Idempotent Chef LWRP for creating, adding, removing and deleting SSH Deploy Keys on Bitbucket and Github
https://supermarket.getchef.com/cookbooks/deploy_key
Other
44 stars 27 forks source link

make sure directory exists before placing files #7

Closed dwradcliffe closed 10 years ago

c10l commented 10 years ago

I'm not sure the creation of the directory belongs in this cookbook. Chiefly considering that you're setting the owner and group the same ones as the key itself.

If someone wants to put all their deploy keys in a shared directory, where each key belongs to the app's user, this new resource declaration will leave the directory with unpredictable ownership.

Thoughts?

dwradcliffe commented 10 years ago

After some thought, I agree with you.