search

c10l / cookbook-deploy_key

Idempotent Chef LWRP for creating, adding, removing and deleting SSH Deploy Keys on Bitbucket and Github
https://supermarket.getchef.com/cookbooks/deploy_key
Other
44 stars 27 forks source link

Fix http urls #9

Closed alvassin closed 9 years ago

alvassin commented 9 years ago

Removed ssl checks for http urls

c10l commented 9 years ago

Sorry, but I fail to understand why you'd want to use insecure SSL. I certainly don't want my automation software blindly accepting any home baked certs and MITMs out there.

alvassin commented 9 years ago

@cassianoleal if you don't want to - use https urls. Why not?

c10l commented 9 years ago

@alvassin I'm terribly sorry, I misread your code completely.

I'm not on the computer right now but I'll give it a second look when I am.

Just so I understand, why is that if necessary? What fails without it?

c10l commented 9 years ago

Ok, got it. I guess I had never tested this with plain HTTP.

Thanks for this pull request!

alvassin commented 9 years ago

Thanks a lot, @cassianoleal. Much appreciated.

c10l commented 9 years ago

No worries! I've published a point release 2.0.1 with this fix. Cheers! :beers: