c12i / mpesa-rust

A MPESA API sdk in Rust
https://c12i.github.io/mpesa-rust/mpesa/index.html
MIT License
43 stars 14 forks source link

Test failure. #74

Closed Borwe closed 11 months ago

Borwe commented 11 months ago

This test fails, test_client_will_not_authenticate_with_sandbox_credentials_in_production it asserts true, when it should assert false on some secrets and key combos.

I suspect that some combos are actually used by Safaricom in production, like mine were which I just created an account on sandbox today. Possible solution? Remove test all together. image

c12i commented 11 months ago

Strange, this test should probably be removed due to it's flaky nature. I had actually removed reliance on safaricom's unreliable sandbox env for testing, this was the only test that survived the purge.

c12i commented 11 months ago

Good catch though, feel free to create a PR for this

Borwe commented 11 months ago

PR created :+1: