c12i / mpesa-rust

A MPESA API sdk in Rust
https://c12i.github.io/mpesa-rust/mpesa/index.html
MIT License
43 stars 14 forks source link

Enable and add missing doc tests against sandbox API #90

Closed c12i closed 9 months ago

c12i commented 9 months ago

Closes #82 Closes #37

Changes

Fixes

TODO

Findings

c12i commented 9 months ago

Flaky tests:

c12i commented 9 months ago

The C2b simulate API seems to not exist in the docs anymore

c12i commented 9 months ago

Hey @crispinkoech I noticed that whenever I call the bill_manager APIs in sandbox, I get a 401 invalid access token error. Is this something you had encountered when you tested this out?

c12i commented 9 months ago

Hey @crispinkoech I noticed that whenever I call the bill_manager APIs in sandbox, I get a 401 invalid access token error. Is this something you had encountered when you tested this out?

Just realized the current app I am using to make this call does not have access to the bill manager APIs

crispinkoech commented 9 months ago

Hey @crispinkoech I noticed that whenever I call the bill_manager APIs in sandbox, I get a 401 invalid access token error. Is this something you had encountered when you tested this out?

I don't recall, it's been a while 😅

c12i commented 9 months ago

Hey @crispinkoech I noticed that whenever I call the bill_manager APIs in sandbox, I get a 401 invalid access token error. Is this something you had encountered when you tested this out?

I don't recall, it's been a while 😅

No worries, I figured out the cause, my app did not have access to bill manager.

ION, the bill manager api is due for a refactor, I noticed that there are some new changes to the APIs that break the current implementation, will create an issue for this.

crispinkoech commented 9 months ago

No worries. You can assign that to me (as well as the other issue I created, seems I don't have access for that)

itsyaasir commented 9 months ago

@c12i Quick suggestion; The docs are looking good, should we add more information to the module about the service itself, maybe example response or example request ?

We can include the docs in the module itself, something like #![doc = include_str!("../../docs/client/dynamic_qr.md")]