c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
81 stars 43 forks source link

Improvements to the top of the vertical stabilizer #1030

Closed legoboyvdlp closed 6 years ago

legoboyvdlp commented 6 years ago

Hi there, A few more problems: image

Here we see that there are some strange lines on the top of the vertical stabalizer, with the N35799 livery.

OH-CTL was the other livery which I tested, which also presents the error: image

Also, the model of the nav light is very unsmooth and not a great model:

This shows the top of the tail and light of a real Cessna: image

I circled a few things that in particular would be nice to have modelled: image

wlbragg commented 6 years ago

Good catch on the tail light. I don't think it is even UV mapped at this point.

wlbragg commented 6 years ago

There is tons of minor modeling upgrades (major ones too) that one could do on this aircraft. So if people want to identify these potential upgrades and make TODO issues for them go ahead. If someone else wants to do any of this remodeling, go for it.

All I did was to separate the current tail light and UV map it same as the other nav lights are. That is really all I am interested in doing.

@gilbertohasnofb we don't have to do this but to be consistent we probably should add a rudder nav light texture to the fuselage sheet. Below its the current mapping I did for the new rudder nav light object. nav

@legoboyvdlp that stripe coloring on top of the rudder is actually caused by the reflect shader, what your seeing is some part of the reflection cube we are using for c172p. There is nothing we can do about it as far as I am aware other than reshape the top of the rudder.

gilbertohasnofb commented 6 years ago

@wlbragg sure, I will work on it right now.

gilbertohasnofb commented 6 years ago

I just renamed this since now that light is textured but the suggested improvements to the 3D model have not been done. As @wlbragg I think we are both fine with the current state of the outside model (we need to find a point to stop and move on to other things) and now we plan to tackle the interior. But nevertheless we leave this opened sos that in the future these can still be considered.

legoboyvdlp commented 6 years ago

I've been learning Blender. I'm not too confident, but perhaps after the interior work, I might be able to have a go. I will not promise that I can do it. But if I can, I will.

gilbertohasnofb commented 6 years ago

@wlbragg I think if we did only two or three small improvements we could potentially close this issue as well:

wkitty42 commented 6 years ago

quick off-topic question about the photos above... the light on the top is the tail beacon and the one on the back is the white navigation light that goes with the red and green on the wings... what is the rectangular one on the side under the beacon? is there one on the other side in the same place? is this a tail strobe that would go with the wing strobes... i'm asking for my small AI GA craft lighting project...

legoboyvdlp commented 6 years ago

That's an aerial for something - not sure what, but IIRC for VORs.

wkitty42 commented 6 years ago

erk! you're right... i see the stiff wire coming out of it now... i was hung up on some craft having more than two strobes on them... apparently some also have some additional ones on the tail area... thanks for the info :smile_cat:

wlbragg commented 6 years ago

@gilbertohasnofb here is the first pass at retopologizing the tail section. I haven't touched the texturing. It will need to have the UV partially remapped. Please review and point out any issues when you get a chance.

tail

wlbragg commented 6 years ago

tail2

gilbertohasnofb commented 6 years ago

@wlbragg wow, this is an incredible work. This is a thousand times better. :clap: :clap: :clap:

The absolutely only single minor thing is that the beacon lamp is floating a bit above the tail, see:

fgfs-screen-002

gilbertohasnofb commented 6 years ago

@wlbragg please do a git pull as I pushed some bug fixes to OH-CTL's tail texture and I also fixed the position of the IFR view as it was not changed after we lifted the cockpit.

legoboyvdlp commented 6 years ago

Is it just me or is the top of the stabalizer slightly bent towards the camera after the circled part? Or perhaps that's just texturing.

image

wlbragg commented 6 years ago

@legoboyvdlp there were two stages of work done on the stabilizer portion. I felt as it was pointing down after commit 76d16dc so I adjusted it to be more level at the top line in commit 00ac1d7 That also required moving the lamp mesh up ever so slightly. I didn't adjust the light however as it was so minuscule it wasn't worth it. @gilbertohasnofb I fixed the gap in the beacon lamp.

gilbertohasnofb commented 6 years ago

@wlbragg I found another issue, the VOR antennas are not touching the stabilizer:

image

image

wlbragg commented 6 years ago

Wow, I'm slipping, can't believe I missed that, thanks for catching it. It's pushed.

gilbertohasnofb commented 6 years ago

Thanks, I confirm this is fixed.

gilbertohasnofb commented 6 years ago

@wlbragg I've found a small bug, the strobe light isn't aligned any longer with the lamp. Also notice that there is a squareness to the light for some reason:

image

Also, (and please don't kill me and feel free to say no), I would like to suggest a couple of small improvements to the front part of the vertical stabilizer, if you think any of this would be possible. Using this reference:

image

We could:

That is, going from this:

image

To this:

image

(open them in two tabs and flick between them to see the differences)

Needless to say none of this is super high priority, so just let me know your thoughts.

wkitty42 commented 6 years ago

On 08/04/2018 02:40 PM, Gilberto Agostinho wrote:

  • move the strobe light a bit backwards
  • strobe light should be shorter in height
  • the base of the strobe light should be really short
  • the strobe lamp should be a dark unglowing red colour when off

do you mean the beacon? beacons are red whereas strobes are a brilliant blueish white when they flash... think of strobe lights in a disco or dance club... the ones that make everything look like stop-motion... like when fan blades are moving but they look like they are still...

there are a lot of folks that mix these up... they say strobe when they mean beacon... beacons are the red ones that used to revolve and shine their light as a beam but now generally just blink omni-directionally... they are located on the top of the tail or fuselage and possibly there may be one on the belly of the fuselage... strobes are generally on the wing tips with the navigation lights and maybe on the tail with the white tail navigation light...

gilbertohasnofb commented 6 years ago

Yeah, nice catch, I meant the red beacon.

wlbragg commented 6 years ago

@gilbertohasnofb I think all of that is easily doable with the possible exception of the lip protecting the airflow over the beacon lamp. You can see I tried to recess that at the time I worked on it, I may have just been lazy as to why I didn't do it then, or it was proving to be to difficult. I'll see what I can do.

FYI: I am in the middle of light map correction, it's a bitch. We did so much customization prior, it is all I can do now. I can't simply re-run whole maps for the interior, panel and panel-parts. Lots of cutting and paste. But it'll work. The next person that come along to work on this will hate us!

gilbertohasnofb commented 6 years ago

FYI: I am in the middle of light map correction, it's a bitch. We did so much customization prior, it is all I can do now. I can't simply re-run whole maps for the interior, panel and panel-parts. Lots of cutting and paste. But it'll work. The next person that come along to work on this will hate us!

Oh please don't worry about that! Just make sure to generate the new light maps containing the new objects and let me do the copy pasting into the customized maps, I have all modified files in my folder. And actually the light map is the least of my concern as most new objects are small and simple and I could just fake it with GIMP. Please dont' go too crazy with it, ok?

wlbragg commented 6 years ago

Actually it's the baking that is the time killer for me. I find it almost impossible to get consistent bakes, especially over time, with Blender. There are too may settings and variables. One way for AO and another for light maps. Add into that all the customization I had to do in the blend to get a map that has shadows for some things but not for others, whew.

I'll tell you what then. I already did lm-panel.png as it is a very special and customized map, done in many stages. I'll push what I did and also include lm-panelORG.png which is the original before my changes so you can look at it and verify all is well.

Then I will gladly post the new bakes lm-panel-parts and lm-interior for you to do the cut and paste from. I should have them in an hour or so.

Then I will do the same for the AO and post it for you to combine the new parts into your master.

Apologies for cluttering this thread with "off topic" stuff.

gilbertohasnofb commented 6 years ago

@wlbragg perhaps do not push the new bakes but just post them here, so that I can just take a look at them before we commit them, would that be all right?

Apologies for cluttering this thread with "off topic" stuff.

No worries, we don't have an opened issue for that and we are multitasking a million issues at the same time, it's all good.

wkitty42 commented 6 years ago

On 08/04/2018 03:06 PM, Gilberto Agostinho wrote:

Yeah, nice catch, I meant the red beacon.

not a problem... i was real hopeful that it wouldn't come across offensively...

wlbragg commented 6 years ago

Done!

gilbertohasnofb commented 6 years ago

Fantastic, looks great!!