search

c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
82 stars 43 forks source link

Correct a segfault caused when you lower and then raise the amphibious gear on land #1285

Closed wlbragg closed 5 years ago

wlbragg commented 5 years ago

Fixes #1284

gilbertohasnofb commented 5 years ago

@wlbragg I still can't run FG but the code looks good and you certainly tested that the segfault is fixed with this. Given the urgency of the fix I am merging this. Should we bother Stuart once again for yet another cherry-pick + merge?

wlbragg commented 5 years ago

@gilbertohasnofb I pinged Stuart with this. If he gets it into the release we can then cherry pick it to our release branch. Thanks for getting it merged.

dany93 commented 5 years ago

@wlbragg @gilbertohasnofb

I have tested it, it works with no problem. Lowering and then raising the amphibious gear on land gave no fault.

For testing, I could reproduce the issue in my previous git pull, In my previous git pull, I got:

In file /home/dany/FG/github/c172p/Systems/c172p-ground-effects.xml: line 1277
Malformed conditional check in function definition.
Fatal error (const char*): Fatal Error.

and the simulator was completely freezed.

Your commit fixed it.

stuartbuchanan commented 5 years ago

Hi Folks,

Please push this to your 2019.1 release branch so myself or James can merge it in.

Also, not sure if the commit to fix the warning messages was also merged into your branch - I merged the changes manually into fgdata. If not, please push those also.

Thanks!

-Stuart

wlbragg commented 5 years ago

I won't be able to do this until later on this evening about 6 hours from now. I will take care of it then if no one beats me to it.

wlbragg commented 5 years ago

@stuartbuchanan release/2019.1 is ready. https://github.com/c172p-team/c172p/commit/c4ca3ab7396a19ceeb5eea7f03b1c56a7a411de4 All other bug fixes are already in fgdata. Thanks!