c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
82 stars 43 forks source link

KX165A COM2 problems - tuning and selecting 8.33khz and 25khz #1326

Open wkitty42 opened 4 years ago

wkitty42 commented 4 years ago

holding shift and clicking on the middle knob of the tuner knobs doesn't always switch between 8.33k and 25k... sometimes i have to do it a 2nd time... this happens on both COM1 and COM2...

on COM2, i can rotate the middle knob of the tuner knobs with my mouse but the khz numbers do not change with each movement of the knob in either mode...

i was going to test something being discussed on the dev mailing list and thought i'd set COM1 to 25k and COM2 to 8.33k and then tune the freqs they are talking about and see what the radios do... since this is also now a three decimal display, i was not going to try to look at or understand the two decimal display problem also being talked about in that thread...

wkitty42 commented 4 years ago

NVM - i wasn't rotating the knobs far enough... i'm still not sure about the clicking of the middle knob but that might also have been due to all the logging i have going on when in debug mode in gdb...

sorry for the noise...

gilbertohasnofb commented 4 years ago

@wkitty42 no worries, thanks for the report anyway!

callahanp commented 4 years ago

I noticed the same thing recently under gdb. One of the knobs wouldn't respond at all to click/drag. could change the mhz, but not the khz. And only on com1 Com2 worked fine.

On Tue, Jul 14, 2020 at 12:24 PM Gilberto Agostinho < notifications@github.com> wrote:

@wkitty42 https://github.com/wkitty42 no worries, thanks for the report anyway!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/c172p-team/c172p/issues/1326#issuecomment-658278184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOZDUHLHDWIAIJTR245QSDR3SBFDANCNFSM4OZU3ZVA .

dany93 commented 4 years ago

I find that the toggle effect on 8.33 <--> 25 kHz step is correct. Generally, all clicks, drag, scroll wheel controls worked well at changing the frequencies.

However, once out of several (7 to 10?) attempts without knowing why, the central button on 'COM1 (kHz)' wouldn't respond at all, permanently. Like @callahanp. The animation (rotate) worked, but no effect on the displayed frequencies. No error message in the console at the default ( = alert) level. Solved only by exit and restart. I could not reproduce it.

One (reproducible for this one) issue might come from a <repeatable>true</repeatable> tag when shift-clicking on the central button, to toggle between 8.33 to 25 kHz. If I observe it well (zooming and highlighting by Ctrl-C helps), a held shift-click makes it pull and push quickly during this time. Which can be confusing if one presses the mouse left-button a bit too long.

Although I don't understand, I see in kx165.xml, line 818

        <shift-action>
            <repeatable>0</repeatable>
            <binding>
                <command>property-cycle</command>
                <property>instrumentation/comm[0]/channel-mode-selector</property>
                <value>0</value>
                <value>1</value>
            </binding>
        </shift-action>

Which seems correct (repeatable = 0 = false?). Only for <shift action>? Or should <shift-repeat> be used?

FG next 2020.3.0 (18 Jun 2020) Linux Mint 18 c172p commit 59a48a4f5edc (Feb 3, 2020)

wkitty42 commented 4 years ago

if this is working like many languages, then yes... zero is false and non-zero is true...

dany93 commented 4 years ago

Despite <repeatable>0</repeatable>, a held shift-click makes the 25 / 8.33 pull and push button toggling several times per second. I tried <repeatable>false</repeatable>, same effect.

I also tried replacing it for <shift-repeat> = 0, or 10, or 1000, no change.

dany93 commented 4 years ago

Dany wrote

a held shift-click makes it pull and push quickly during this time. Which can be confusing if one presses the mouse left-button a bit too long

@legoboyvdlp, do you know if something can be done to fix this "repeatability"?

legoboyvdlp commented 4 years ago

<repeatable> set to false should do it :)

dany93 commented 4 years ago

Dany wrote (on 18 july 2020)

I tried <repeatable>false</repeatable>, same effect.

legoboyvdlp commented 4 years ago

Sorry - missed that. :)

This is a conflict between the action which isn't repeatable and explicit shift action which is repeatable.

This is almost certainly something for the bug tracker?